Stamp image tags from STABLE_ status keys - #80
Open
matx-sjacob wants to merge 1 commit into
Open
Conversation
matx-sjacob
marked this pull request as draft
August 5, 2026 18:13
matx-sjacob
force-pushed
the
sjacob/stable-stamp-keys
branch
from
August 6, 2026 09:43
163b456 to
8ca266e
Compare
matx-sjacob
marked this pull request as ready for review
August 6, 2026 09:48
matx-sjacob
force-pushed
the
sjacob/stable-stamp-keys
branch
2 times, most recently
from
August 6, 2026 21:49
a83cd52 to
4fbd910
Compare
Author
|
@EdSchouten a review on this would be much appreciated. Thanks! |
matx-sjacob
force-pushed
the
sjacob/stable-stamp-keys
branch
from
August 20, 2026 15:36
4fbd910 to
18a6367
Compare
BUILD_SCM_REVISION and BUILD_SCM_TIMESTAMP land in volatile-status.txt, whose digest Bazel reports as unchanging, so the bb-storage expand_template that turns them into the image tag is never invalidated: on a machine with a persistent cache, every build reuses the first build's tag and silently overwrites whatever was published there. Rename the keys with the STABLE_ prefix and bump bb-storage to 33530b6 so the pinned template expects the new names. The bump drags along bazel_remote_apis (becdd8f, carrying the same upstream-pr-378.diff patch bb-storage applies, since the root override replaces bb-storage's) and a go.mod/go.sum refresh, with cel.dev/expr pinned back to 0.25.1 the same way bb-storage does. Co-Authored-By: Claude <noreply@anthropic.com>
matx-sjacob
force-pushed
the
sjacob/stable-stamp-keys
branch
from
August 20, 2026 15:45
18a6367 to
b2e0bb2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related buildbarn/bb-storage#358
BUILD_SCM_REVISIONandBUILD_SCM_TIMESTAMPhave noSTABLE_prefix, so Bazel files them involatile-status.txtand reports an unchanging digest for that file whatever it contains. Theexpand_templatein bb-storage that turns them into the image tag is therefore never invalidated, and_stamped.tags.txtis generated once and reused indefinitely — on a build machine whose cache persists, every later build pushes its image to the tag produced by the first build on that machine.The bb-storage bump is part of the fix: that template is what expands these keys, and the pin here predates
33530b6, which switched it to the prefixed names.The rest follows from that bump, each uncovered by fixing the one before it:
.bazelversion9.0.0rc1 → 9.1.0 — bb-storage pullsgrpc@1.80.0, wantingrules_swift@2.5.0(compatibility level 2), while the bundledbazel_toolswants 3.1.2 (level 3)go.mod/go.sum— the Go graph still resolved bb-storage at the old commitbazel_remote_apis→becdd8f, matching whatgo.modselects; while these disagreed, gazelle would not generatecom_github_bazelbuild_remote_apisand bb-storage'suse_repoof it failedVerified by building
@com_github_buildbarn_bb_storage//tools:stamped_tags, which now yields20260806T094329Z-8ca266efor HEAD instead of a frozen value.Two things for a maintainer's eye. The
.github/workflowsfiles are generated from bb-storage's template, which changed between these two pins — regenerating alters build flags and renames the release binary tobb_remote_asset.linux_amd64, so I left it out of this PR. And bb-remote-execution carriespatches/bazel_remote_apis/upstream-pr-378.diffat this same commit; nothing here needs the repos it restores, so I have not added it.