Skip to content

fix(logging): credentials in headers are leaked via log - #81

Open
Links2004 wants to merge 2 commits into
buildbarn:mainfrom
mercedes-benz:MB/upstream/fix_header_logging
Open

fix(logging): credentials in headers are leaked via log#81
Links2004 wants to merge 2 commits into
buildbarn:mainfrom
mercedes-benz:MB/upstream/fix_header_logging

Conversation

@Links2004

Copy link
Copy Markdown
Contributor

this implements a whitelist for Qualifier headers that are allowed to by logged.

fixes: #77

Markus Sattler, Mercedes-Benz Tech Innovation GmbH

Provider Information

@cameron-martin

Copy link
Copy Markdown

@Links2004 it looks like linting failed on CI

@Links2004
Links2004 force-pushed the MB/upstream/fix_header_logging branch from b71a60d to 108bdd5 Compare September 2, 2026 09:55
@Links2004

Copy link
Copy Markdown
Contributor Author

@cameron-martin did rebase and bazel run @com_github_buildbarn_bb_storage//tools:reformat

@cameron-martin

Copy link
Copy Markdown

Looks like it's still failing on the same issue

@Links2004

Copy link
Copy Markdown
Contributor Author

interesting, did apply the patch manually.
very strange that the local run did not find it, need to look in to that when i have some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Credentials are leaked via logfiles

2 participants