refactor(ci): buildifier check on Aspect#296
Open
alexeagle wants to merge 3 commits intobuildbarn:mainfrom
Open
refactor(ci): buildifier check on Aspect#296alexeagle wants to merge 3 commits intobuildbarn:mainfrom
alexeagle wants to merge 3 commits intobuildbarn:mainfrom
Conversation
Generally with GHA config in YAML it seems impossible to use any tools like renovate, is that good?
It has a nicer DX for showing failures, and will soon let you apply suggested fix
|
Member
|
Hey Alex, Right now we indeed run a bunch of formatters as CI steps. However, the downside is that it makes it hard to run locally. For our internal development we just have a shell script at the root of the repository that can run all the formatters the correct way. @jpopadak was working on tidying that up, so that we can merge it into this repo: So I don't think we should move formatters from one CI system to another. We should get rid of them altogether, and eventually just run the formatting script and report the diff that comes out of that. However, I do think it makes sense to move linting steps over (e.g., glint). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It has a nicer DX for showing failures, and will soon let you apply suggested fix.
Also upgrade actions/checkout