Open
Conversation
A user reported that the test grid could show cached tests as non-cached. That happened because test target history inferred cache state from timestamps and flattened multiple test attempts down to a lossy bool. This change keeps target history test-only, adds explicit local, remote, and total cached attempt counts to ClickHouse-backed test history, and updates the TAP grid to derive full versus partial cache state from those fields. The primary DB path stays on the legacy bool, and cached remains in TargetStatus as a fallback for older ClickHouse rows that do not have the new count columns yet. This requires an additive ClickHouse migration for TestTargetStatuses. Older rows still render via the legacy bool and timestamp heuristic until they are rewritten, while new rows carry the full cache-attempt semantics.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A user reported that the test grid could show cached tests as
non-cached. That happened because test target history inferred cache
state from timestamps and flattened multiple test attempts down to a
lossy bool.
This change keeps target history test-only, adds explicit local,
remote, and total cached attempt counts to ClickHouse-backed test
history, and updates the TAP grid to derive full versus partial
cache state from those fields. The primary DB path stays on the legacy
bool, and cached remains in TargetStatus as a fallback for older
ClickHouse rows that do not have the new count columns yet.
This requires an additive ClickHouse migration for TestTargetStatuses.
Older rows still render via the legacy bool and timestamp heuristic
until they are rewritten, while new rows carry the full cache-attempt
semantics.