Open
Conversation
Contributor
|
I think this is an interesting idea and I'd be down to try it out. I see this PR is marked as a "draft" -- are you still working on it, or should I take a look? |
Contributor
|
BTW, if we are going to use the target label, maybe the package label would be even better. |
Review feedback asked the affinity experiment to group by package because the full target label still splits sibling targets in the same package. Use the Bazel package label instead, so related actions such as //foo/bar:foo_lib and //foo/bar:foo_test can share warmed executors. Keep the existing first-output fallback when request metadata is missing. Cover selected-org, control-org, same-package, and different-package behavior in task_router tests.
sluongng
force-pushed
the
sluongng/task-router-target-label-affinity
branch
from
1e4d537 to
61afdd3
Compare
sluongng
changed the title
bduffany
approved these changes
Apr 28, 2026
| // Preferred node limit for tasks using [persistentWorkerRouter]. | ||
| persistentWorkerRouterPreferredNodeLimit = 128 | ||
|
|
||
| affinityRouterUseTargetLabelExperiment = "remote_execution.affinity_router_use_target_label" |
Member
There was a problem hiding this comment.
Suggested change
| affinityRouterUseTargetLabelExperiment = "remote_execution.affinity_router_use_target_label" | |
| affinityRouterUseTargetPackageExperiment = "remote_execution.affinity_router_use_target_package" |
iain-macdonald
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review feedback asked the affinity experiment to group by package because
the full target label still splits sibling targets in the same package.
Use the Bazel package label instead, so related actions such as
//foo/bar:foo_lib and //foo/bar:foo_test can share warmed executors.
Keep the existing first-output fallback when request metadata is missing.
Cover selected-org, control-org, same-package, and different-package
behavior in task_router tests.
Testing: