[WF] Add logic to dispatch scheduled workflows#12007
Open
maggie-lou wants to merge 2 commits intomasterfrom
Open
[WF] Add logic to dispatch scheduled workflows#12007maggie-lou wants to merge 2 commits intomasterfrom
maggie-lou wants to merge 2 commits intomasterfrom
Conversation
maggie-lou
force-pushed
the
dispatch_scheduled
branch
2 times, most recently
from
3115e86 to
f5307a1
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds server-side support for dispatching workflows on a cron-like schedule by introducing a ScheduledRun table and a WorkflowService entrypoint to claim + dispatch due runs.
Changes:
- Register
ScheduledRunas a DB table and exposeRunScheduledWorkflows()onWorkflowService. - Implement scheduled-run claiming/leasing, dispatch, and next-run calculation logic in the workflow service.
- Add tests for scheduled workflow dispatching, including a concurrent-scheduler scenario, and add new cron/time dependencies.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| server/tables/tables.go | Registers the ScheduledRun table type for DB migrations/registration. |
| server/interfaces/interfaces.go | Extends WorkflowService with RunScheduledWorkflows(ctx) API. |
| enterprise/server/workflow/service/service.go | Implements scheduled workflow claiming, leasing, dispatch, and cron-based next-run computation. |
| enterprise/server/workflow/service/service_test.go | Adds tests covering scheduling behavior and multi-server concurrency. |
| go.mod / go.sum | Adds github.com/robfig/cron/v3 dependency. |
| enterprise/server/workflow/service/BUILD | Wires new Go deps (cron, clockwork) into Bazel targets. |
| deps/go_deps.MODULE.bazel | Adds Bazel module repo for robfig/cron/v3. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
maggie-lou
force-pushed
the
dispatch_scheduled
branch
5 times, most recently
from
dfab8a6 to
e3d0935
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 11 out of 12 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
maggie-lou
force-pushed
the
dispatch_scheduled
branch
from
e3d0935 to
68f7b6e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.