test: add E2E tests for probe behavior - #11
Merged
Conversation
Add e2e-probe-behavior job that validates: - Liveness probe configuration (redis-cli ping) - Readiness probe configuration (ready.sh script) - Liveness probe triggers pod restart on Redis failure - Master pod is Ready - Synced replica pods are Ready - Sentinel liveness probe configuration - Redis cluster functionality after probe tests Part of issue #5
- Use custom probe timings for faster tests (20s vs 120s for liveness) - Write 1000 keys to test replication works - Verify data replicates to replicas - Test replica resync: delete replica, verify it becomes Ready - Test data survives pod restarts/failover - Verify Sentinels are Ready - Final functionality check with new data
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds E2E tests validating current probe behavior as a baseline before replacing process-spawning probes with instance manager HTTP endpoints.
Fixes #5
Test Coverage
Behavioral Tests (Implementation Agnostic)
Test Optimizations
Why This Matters
These tests validate outcomes, not mechanisms. When we swap the probes:
redis-cli ping→/healthzHTTP endpointready.shscript →/readyzHTTP endpointThe same tests should pass. If they do, the swap was successful.
Test Plan