feat: replace liveness probe with httpGet when instance manager enabled - #13
Merged
Conversation
When instanceManagerImage is set, use HTTP liveness probe to /healthz:8080 instead of spawning redis-cli processes. This follows the CNPG model and provides better performance under memory pressure. Changes: - Use httpGet probe to /healthz:8080 when instance manager enabled - Fall back to exec probe (redis-cli) when instance manager not enabled - Expose health port 8080 in container spec when instance manager enabled Benefits: - No process spawning (~50ms savings per probe) - Works better under memory pressure - Simpler probe configuration Backwards compatible: only applies when instanceManagerImage is set. Fixes #7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the process-spawning liveness probe with an HTTP probe to
/healthz:8080when instance manager is enabled.Fixes #7
Changes
instanceManagerImagesethttpGet /healthz:8080instanceManagerImagenot setexec redis-cli ping(legacy)Before (exec probe)
Problems:
After (httpGet probe)
Benefits:
Backwards Compatibility
instanceManagerImageis setTest Coverage
Test Plan