feat: replace readiness probe with httpGet when instance manager enabled - #14
Merged
Conversation
usiegj00
force-pushed
the
feature/httpget-readiness-probe
branch
from
January 25, 2026 05:20
b4ff3fe to
951c5fb
Compare
Use HTTP GET probe to /readyz:8080 for readiness when instance manager is enabled, falling back to legacy exec probe otherwise. - Add instanceManagerReadyzPath constant - Update readiness probe generation to use httpGet when enabled - Add unit tests for HTTP and exec readiness probes - Add E2E tests to verify httpGet readiness probe configuration - Add no-master-configured check to /readyz for ready.sh parity Fixes #8
usiegj00
force-pushed
the
feature/httpget-readiness-probe
branch
from
January 25, 2026 05:20
951c5fb to
18877f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the process-spawning readiness probe with an HTTP probe to
/readyz:8080when instance manager is enabled.Fixes #8
Changes
instanceManagerImagesethttpGet /readyz:8080instanceManagerImagenot setexec ready.sh(legacy)Operation Comparison: ready.sh vs /readyz
loading:1master_sync_in_progress:1master_host:127.0.0.1master_link_status:downThe
/readyzendpoint covers all ready.sh checks plus additional safety checks.Before (exec probe)
Problems:
After (httpGet probe)
Benefits:
Backwards Compatibility
instanceManagerImageis setTest Plan