Open
Conversation
bbd80c1 to
0f15b75
Compare
0f15b75 to
147541e
Compare
147541e to
bd22665
Compare
bd22665 to
509008b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ensure that, when removing all files and directories for a cleanup, that directories with weird permissions (e.g. lacking execute bit) are cleaned up.
Context
#2941
Changes
hardRemoveAllhelper function that tests for permissions problems after failing toos.RemoveAll, in a loopos.RemoveAllwith a call tohardRemoveAllTesting
go test ./...). Buildkite employees may check this if the pipeline has run automatically.go fmt ./...)