Add config option to fail pipeline upload on parsing warnings as well as errors#3304
Open
nic-littlepay wants to merge 6 commits intobuildkite:mainfrom
Open
Add config option to fail pipeline upload on parsing warnings as well as errors#3304nic-littlepay wants to merge 6 commits intobuildkite:mainfrom
nic-littlepay wants to merge 6 commits intobuildkite:mainfrom
Conversation
nic-littlepay
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Attempts to provide fixe for issue #3303
Context
There's slightly more context in the issue but broadly we wanted to be able to configure the agent to fail pipeline if it finds parse warnings in pipeline upload.
Changes
true, returns error on parse warnings.Testing
go test ./...). Buildkite employees may check this if the pipeline has run automatically.go fmt ./...)