Merged
Conversation
Signed-off-by: Tom Watt <tom@buildkite.com>
Signed-off-by: Tom Watt <tom@buildkite.com>
Signed-off-by: Tom Watt <tom@buildkite.com>
Signed-off-by: Tom Watt <tom@buildkite.com>
Signed-off-by: Tom Watt <tom@buildkite.com>
Signed-off-by: Tom Watt <tom@buildkite.com>
Signed-off-by: Tom Watt <tom@buildkite.com>
Signed-off-by: Tom Watt <tom@buildkite.com>
tomowatt
force-pushed
the
add-gcp-kms-signing
branch
from
c1d7e6d to
15f7e08
Compare
…ey usage Signed-off-by: Tom Watt <tom@buildkite.com>
quinn-diesel
requested review from
CerealBoy,
DrJosh9000,
moskyb,
quinn-diesel,
wolfeidau and
zhming0
DrJosh9000
reviewed
Feb 2, 2026
DrJosh9000
reviewed
Feb 2, 2026
DrJosh9000
reviewed
Feb 2, 2026
DrJosh9000
reviewed
Feb 2, 2026
DrJosh9000
reviewed
Feb 2, 2026
Signed-off-by: Tom Watt <tom@buildkite.com>
Signed-off-by: Tom Watt <tom@buildkite.com>
Signed-off-by: Tom Watt <tom@buildkite.com>
…gest Signed-off-by: Tom Watt <tom@buildkite.com>
Signed-off-by: Tom Watt <tom@buildkite.com>
Signed-off-by: Tom Watt <tom@buildkite.com>
Signed-off-by: Tom Watt <tom@buildkite.com>
Member
Author
|
Re-tested with the changes made and can verify still working. |
tomowatt
force-pushed
the
add-gcp-kms-signing
branch
from
a2ab036 to
34a4a34
Compare
DrJosh9000
approved these changes
Mar 24, 2026
Contributor
DrJosh9000
left a comment
DrJosh9000
left a comment
There was a problem hiding this comment.
Sorry for the delay. This is great! Let's 
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, only AWS KMS and JWKS key pairs can be used for Signing and Verification of Jobs. As we have many customers on GCP, this allows them to use GCP KMS as well.
Context
We've had a few customers ask for more support on GCP with the Agent
Changes
The changes are to the following commands:
buildkite-agent pipeline uploadbuildkite-agent tool signbuildkite-agent startAdding the following Flag:
Testing
go test ./...). Buildkite employees may check this if the pipeline has run automatically.go tool gofumpt -extra -w .)This has also been tested locally with using
gcloudto explicitly set up the credentials and also within in GCloud Console where the credentials were not explicity configured.Disclosures / Credits
I used Claude Code to write the code and unit tests. Based on the documentation from Google on their SDK and usage of KMS