Enable setting BUILDKITE_GIT_SUBMODULE with Environment Variables#3677
Open
Enable setting BUILDKITE_GIT_SUBMODULE with Environment Variables#3677
Conversation
* defaults to true for backwards compatibility Signed-off-by: Tom Watt <tom@buildkite.com>
Signed-off-by: Tom Watt <tom@buildkite.com>
Signed-off-by: Tom Watt <tom@buildkite.com>
Signed-off-by: Tom Watt <tom@buildkite.com>
Signed-off-by: Tom Watt <tom@buildkite.com>
Signed-off-by: Tom Watt <tom@buildkite.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently,
BUILDKITE_GIT_SUBMODULEis only configurable via Agent config or during Agent Start, leaving options to disable cloning submodules limited to having plugins to change checkout which can be problematic. So allowing the use of the changingBUILDKITE_GIT_SUBMODULEEnvironment Variable at the Pipeline/Step level or via Hook, allows more flexible and removes need to seek alternative approachs.Agents config takes precendence in the cases that
no-git-submoduleshas already been set.Context
SUP-6018
Changes
Testing
go test ./...). Buildkite employees may check this if the pipeline has run automatically.go tool gofumpt -extra -w .)Disclosures / Credits
I consulted Claude on potential approaches, then wrote the implementation myself based on existing patterns.