chore: Modified mktemp command for tarball extraction on macOS VMs#3698
Open
chrisnavar wants to merge 6 commits intobuildkite:mainfrom
Open
chore: Modified mktemp command for tarball extraction on macOS VMs#3698chrisnavar wants to merge 6 commits intobuildkite:mainfrom
chrisnavar wants to merge 6 commits intobuildkite:mainfrom
Conversation
On MacStadium VMs, the default mktemp is the BSD/macOS version, which does not support the -p option. Even on MacStadium, unless you have specifically installed GNU coreutils and are using gmktemp, mktemp -p will fail. This approach is safe and works in both systems, as long as $DESTINATION exists and is writable. tmp.XXXXXX will create a unique temp directory inside $DESTINATION and avoid the error when the folder already exists.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On MacOS VMs, the default mktemp is the BSD/macOS version, which does not support the -p option. Even on MacOS, unless you have specifically installed GNU coreutils and are using
gmktemp,mktemp -pwill fail. This approach is safe and works in both systems, as long as$DESTINATIONexists and is writable.mp.XXXXXXwill create a unique temp directory inside$DESTINATIONand avoid the error when the folder already exists.Context
mktempcommand.Changes
Testing
go test ./...). Buildkite employees may check this if the pipeline has run automatically.go tool gofumpt -extra -w .)Disclosures / Credits
I consulted Copilot on potential approaches, then wrote the implementation myself.