Batch dangling-instance SSM check#314
Open
scadu wants to merge 2 commits into
Open
Conversation
checkAndMarkUnhealthy used to send one SendCommand per instance and poll GetCommandInvocation in serial loop, so it got slower the more instances there were. This PR changes: 1. DescribeInstanceInformation drops any instance whose SSM agent isn't Online (SendCommand would hang or fail anyway). 2. One SendCommand targets all remaining instances. 3. ListCommandInvocations is polled on a fixed interval until every invocation terminates or deadline elapses, and we act on results received by then. Same outcome per instance: if the check reports NOT_RUNNING or the invocation Failed, SetInstanceHealth marks it Unhealthy; MARKER_EXISTS is skipped.
scadu
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
checkAndMarkUnhealthyused to send oneSendCommandper instance and pollGetCommandInvocationin serial loop, so it got slower the more instancesthere were.
This PR changes:
DescribeInstanceInformationdrops any instance whose SSM agent isn'tOnline (
SendCommandwould hang or fail anyway).SendCommandtargets all remaining instances.ListCommandInvocationsis polled on a fixed interval until every invocation terminates or deadline elapses, and we act on resultsreceived by then.
Same outcome per instance: if the check reports
NOT_RUNNINGor theinvocation
Failed,SetInstanceHealthmarks itUnhealthy;MARKER_EXISTSis skipped.