Blocked build webhook event wording touchup#2497
Closed
Conversation
james2791
requested review from
MelissaKaulfuss,
mbelton-buildkite and
meiqimichelle
as code owners
mbelton-buildkite
approved these changes
Nov 13, 2023
Contributor
mbelton-buildkite
left a comment
mbelton-buildkite
left a comment
There was a problem hiding this comment.
Nice! Thanks for fixing that. I've left one minor nitpick, but otherwise looks good! 😊
Contributor
|
This PR is no longer needed. The file it targeted (pages/apis/webhooks/build_events.md) has been restructured into pages/apis/webhooks/pipelines.md, and the broken sentence ("To if a build is blocked...") no longer exists in the current docs. The content about blocked builds has been rewritten. The PR was approved but never merged, and the fix has been superseded. It can be safely closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a small tweak to the wording of blocked build webhook events (with
build.blockedin the payload)"To if a build..." -> "If a build is blocked"