Add lfs to checkout#78
Open
stephanieatte wants to merge 8 commits into
Open
Conversation
Contributor
|
This looks good as the incremental change for lfs, but before merge it should be restacked/rebased onto the latest checkout branch in the stack (currenlty 73 or 76, I think). |
mcncl
reviewed
May 25, 2026
mcncl
approved these changes
May 25, 2026
Contributor
mcncl
left a comment
mcncl
left a comment
There was a problem hiding this comment.
Approving this on the condition that it aligns with other changes/conflicts are cleaned up. We have a system where the first in seems to decide the state/dictates how things should be shaped
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR branches off #76 and adds
LFS boolas a field to the Checkout struct in the go-pipeline libraryChanges
LFS boolfield toCheckoutwithjson:"lfs,omitempty" yaml:"lfs,omitempty"tagsIsEmpty()andmergeFrom()to account for the new field