Open
Conversation
Attribution: I used Claude to implement this change.
DrJosh9000
approved these changes
Feb 4, 2026
Contributor
DrJosh9000
left a comment
There was a problem hiding this comment.
This is good, I think the main two improvements would be:
- support streaming mode with plain format
- support disabling timestamps with HTML format
If that's something you want to do, I'd be happy to wait, otherwise I don't mind doing it after merging this.
… off which works in both plain and html.
Author
|
@DrJosh9000 both suggestions make sense! I didn't think about streaming, but of course we should do that for plain. And with the timestamps, I made it so they're on by default in plain, as they already were in html. Then added |
DrJosh9000
approved these changes
Feb 5, 2026
Contributor
DrJosh9000
left a comment
There was a problem hiding this comment.
Looks good! I have one suggestion
Co-authored-by: Josh Deprez <josh.deprez@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When working on Support cases I've sometimes had the need to do offline parsing and analysis of job logs. The downloaded log files with included ANSI control characters make that difficult, but converting them to HTML is only one step better. When I mentioned this to @DrJosh9000 he pointed me at #146 and gave me some context around it. But he said he no longer had a need for the JSON output portion of that PR, and it's now so far behind main that it seemed easier to start fresh. This change adds an option to dump a log as raw text, and to include timestamps in that output if desired. That was all I needed.
Attribution: I used Claude to implement this change.