Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CI env var requirement #46

Merged

Conversation

nprizal
Copy link
Contributor

@nprizal nprizal commented Mar 27, 2025

Currently, the test collector doesn’t function if the CI environment is missing. Since there’s no compelling reason to requires a CI environment for running the test collector, we can remove these restrictions.

@nprizal nprizal self-assigned this Mar 27, 2025
@nprizal nprizal requested a review from zhming0 March 27, 2025 23:08
@nprizal nprizal merged commit 3f0b191 into main Mar 28, 2025
11 checks passed
@nprizal nprizal deleted the pie-3529-python-test-collector-should-run-without-citrue-flag branch March 28, 2025 00:22
@nprizal nprizal mentioned this pull request Mar 28, 2025
@nprizal nprizal changed the title Remove CI environment requirement Remove CI env var requirement Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants