Draft
Conversation
This is not an ideal solution: we can probably figure out the limit in advance and then chunk the test cases once, rather than making slices repeatedly while recursing and hitting the same E2BIG errno repeatedly.
This uses an anonymous interface type to define the set of methods needed on the testRunner by main, and introduces a flag as a way to specify the framework type. Aside from the `GoTests` being an empty example, note that there's no environment var that corresponds to the new flag, and there are no flags corresponding to the config currently specified by env var... unifying these might be nice?
PIE-2314 Sketch of support for different testing frameworks/languages
The problem"How to architect the go client in a way that we could easily extend its functionality to include other test runners is other languages and testing frameworks?" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Code I started writing in today's meeting, for future reference (not necessarily intended to be exactly how it should be done)
Context
Run.Changes
mainsyscall.E2BIGerrors fromcmd.Run(good) and recursively split the test cases in half (maybe not so good)Testing
Not tested at all - some of the code isn't bad, but it's intended as a demo.