Bazel Build Event Protocol (BEP) → bktec upload#282
Draft
pda wants to merge 4 commits intobktec-uploadfrom
Draft
Bazel Build Event Protocol (BEP) → bktec upload#282pda wants to merge 4 commits intobktec-uploadfrom
bktec upload#282pda wants to merge 4 commits intobktec-uploadfrom
Conversation
PublishBuildToolEventStream is copied verbatim from bb-portal, and BuildEventHandler and BuildEventChannel interfaces/structs are created to be compatible with that code. This also resolves a bug in the earlier WIP implementation where most event sequence IDs were not acknowledged, resulting in a warning shown on the Bazel side sending the events.
nprizal
reviewed
Mar 24, 2025
| *.dll | ||
| *.so | ||
| *.dylib | ||
| /bktec |
nprizal
reviewed
Mar 24, 2025
| logErrorAndExit(16, "upload: %v", err) | ||
| } | ||
| os.Exit(0) | ||
| } else if flag.Arg(0) == "bazel" && flag.Arg(1) == "listen" { |
Contributor
There was a problem hiding this comment.
[nit] I reckon switch will be more readable now we are most likely going to have many sub-commands.
Member
Author
There was a problem hiding this comment.
Would that be a nested switch?
switch flag.Arg(0) {
case "upload":
…
case "bazel":
switch {
case "listen":
…
default:
…
}
default:
…
}I figured it's simpler to use a flatter if for the moment, and think about whether we want to adopt a bells-and-whistles subcommand/flags package or use some nested switch etc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft, based on #278 which is based on #277
Listen to Build Event Protocol (BEP) / Build Event Service (BES) and upload the XML test result files to Test Engine.
Related:
bktec upload: upload test results to Test Engine #278