Skip to content

Update Storybook dependencies to version 7.6.0 and add test for TextField #816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Update Storybook dependencies to version 7.6.0 and add test for TextField #816

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3e57981
Update Storybook dependencies to version 7.6.0
gabro Nov 28, 2023
83e4cdc
Replace @storybook/testing-library with @storybook-test
gabro Nov 28, 2023
8990294
Update eslint-plugin-storybook version
gabro Nov 28, 2023
77103b0
Add regression test for TextField
gabro Nov 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions packages/bento-design-system/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,15 +143,15 @@
"@react-types/numberfield": "3.5.0",
"@react-types/slider": "3.6.0",
"@react-types/textfield": "3.7.3",
"@storybook/addon-actions": "7.4.0",
"@storybook/addon-essentials": "7.4.0",
"@storybook/addon-links": "7.4.0",
"@storybook/addons": "7.4.0",
"@storybook/builder-vite": "7.4.0",
"@storybook/react": "7.4.0",
"@storybook/react-vite": "7.4.0",
"@storybook/testing-library": "0.2.2",
"@storybook/types": "7.4.0",
"@storybook/addon-actions": "7.6.0",
"@storybook/addon-essentials": "7.6.0",
"@storybook/addon-links": "7.6.0",
"@storybook/addons": "7.6.0",
"@storybook/builder-vite": "7.6.0",
"@storybook/react": "7.6.0",
"@storybook/react-vite": "7.6.0",
"@storybook/test": "^7.6.0",
"@storybook/types": "7.6.0",
"@testing-library/dom": "9.3.3",
"@testing-library/jest-dom": "6.1.4",
"@testing-library/react": "14.0.0",
Expand Down Expand Up @@ -179,7 +179,7 @@
"eslint": "8.48.0",
"eslint-config-react-app": "7.0.1",
"eslint-plugin-sort-export-all": "1.4.1",
"eslint-plugin-storybook": "0.6.13",
"eslint-plugin-storybook": "0.6.15",
"file-loader": "6.2.0",
"jsdom": "22.1.0",
"lint-staged": "13.3.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/bento-design-system/stories/Components/DateField.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import {
addWeeks,
addDays,
} from "date-fns";
import { screen, waitFor } from "@storybook/testing-library";
import { screen, waitFor } from "@storybook/test";
import isChromatic from "chromatic/isChromatic";
import { Meta, StoryObj } from "@storybook/react";

Expand Down
2 changes: 1 addition & 1 deletion packages/bento-design-system/stories/Components/Modal.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { Modal, Body, Placeholder, Stack, CustomModal, Feedback, Inset } from "..";
import { action } from "@storybook/addon-actions";
import { screen } from "@storybook/testing-library";
import { screen } from "@storybook/test";
import { Meta, StoryObj } from "@storybook/react";

const meta = {
Expand Down
13 changes: 13 additions & 0 deletions packages/bento-design-system/stories/Components/TextField.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { TextField } from "..";
import { Meta, StoryObj } from "@storybook/react";
import { within, expect } from "@storybook/test";

const meta = {
component: TextField,
Expand Down Expand Up @@ -43,3 +44,15 @@ export const CustomAccessory = {
rightAccessory: "👍",
},
} satisfies Story;

export const NonDefaultType = {
args: {
value: "[email protected]",
type: "email",
},
play: async ({ canvasElement }) => {
const canvas = within(canvasElement);
const textField = canvas.getByRole("textbox");
await expect(textField).toHaveAttribute("type", "email");
},
} satisfies Story;
Loading