Update docker and go-containerregistry#291
Conversation
jericop
force-pushed
the
update-docker-go-containerregistry
branch
2 times, most recently
from
7ca916f to
95aab00
Compare
| require ( | ||
| github.com/docker/docker v28.1.1+incompatible | ||
| github.com/containerd/errdefs v1.0.0 | ||
| github.com/docker/docker v28.2.2+incompatible |
There was a problem hiding this comment.
We may not be able to do this - we rely on kaniko and it only goes to 28.1.1
#288 (comment) for previous thoughts.
If lifecycle compiles with this commit, I'm happy to give it a go. I think before there were breaking changes but if the versions are compatible enough it could be safe.
There was a problem hiding this comment.
@jericop I updated lifecycle to use the new chainguard fork of kaniko. This resolves the issue I brought up earlier. Get this PR passing checks and DCO. I re-kicked the github test action in case it was a fluke.
There was a problem hiding this comment.
Nice! I figured out the issue and should have this passing now.
Update go-containerregistry from 0.19.1 to 0.20.6 Change toV1Config input type to dockerspec.DockerOCIImageConfig Update and remove deprecated fields and functions Signed-off-by: Jerico Pena <jericop@gmail.com>
jericop
force-pushed
the
update-docker-go-containerregistry
branch
from
5e5d648 to
b579406
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #291 +/- ##
==========================================
- Coverage 38.89% 31.68% -7.21%
==========================================
Files 36 39 +3
Lines 3294 4006 +712
==========================================
- Hits 1281 1269 -12
- Misses 1819 2543 +724
Partials 194 194 🚀 New features to boost your workflow:
|
2 participants
This change does the following:
A corresponding PR to pack has been created, but it will need to be updated to point to the latest commit of imgutil once this change has been merged.
buildpacks/pack#2406