Changes from background agent bc-11074d04-42c8-4e64-828a-811613b5e9e3#4
Draft
buildwithsuhana wants to merge 1 commit intofix_optmfrom
Draft
Changes from background agent bc-11074d04-42c8-4e64-828a-811613b5e9e3#4buildwithsuhana wants to merge 1 commit intofix_optmfrom
buildwithsuhana wants to merge 1 commit intofix_optmfrom
Conversation
Co-authored-by: suhanagun <suhanagun@gmail.com>
|
Cursor Agent can help with this pull request. Just |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes incorrect memory usage reporting in
CoordinatedOptimizerto show accurate total, sharded, and saved memory.Previously, memory usage was incorrectly reported as 0.00 MB or 40 bytes. This PR updates the
CoordinatedOptimizerto correctly identify optimizer states, use zero buffers for accurate size estimation during sharding, and compute memory usage and savings based on variable shapes and dtypes.