#87 uwp: delete calendar event instance #86
Conversation
|
|
||
| Appointment thisEvent = null; | ||
| var instance = await CalendarRequest.GetInstanceAsync(); | ||
| var instance = await CalendarRequest.GetInstanceAsync(AppointmentStoreAccessType.AllCalendarsReadWrite); |
There was a problem hiding this comment.
Is this failing because we need to specify a different permission in manifest file - there was a second calendar permission that allowed for more access I seem to recall
There was a problem hiding this comment.
that rescap thing that you mentioned a while back I could never get working, uwp doesn't seem to understand how to handle it. This was an attempt to see if I could get enough permissions to access calendar events outside of xamarin created calendars, but not sure if it worked off the top of my head, will probably remove at this stage.
| } | ||
| } | ||
|
|
||
| if (uwpAppointment.CalendarId != calendarId) |
There was a problem hiding this comment.
shouldn't this if clause go inside the try-catch?
There was a problem hiding this comment.
I've moved it in, but it's a bit of a custom case, e.g. it won't be caught by the catch, either that or I can also make it throw an argument exception and then put the if logic within the catch, but then I feel like it'd be doubling up the if logic
| try | ||
| { | ||
| throw new ArgumentOutOfRangeException("[UWP]: Supplied event does not belong to supplied calendar"); | ||
| uwpAppointment = await instance.GetAppointmentInstanceAsync(eventId, dateOfInstanceUtc); |
There was a problem hiding this comment.
move declaration in here
ie var uwpAppointment =
No description provided.