-
Notifications
You must be signed in to change notification settings - Fork 0
[size-report] migrate to GitHub Actions #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @bukepo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request streamlines the script/check-size utility by removing its integration with the OT_REPORTER external size reporting mechanism. This change is a foundational step in migrating the project's size reporting capabilities to a GitHub Actions-based workflow, aiming for a more integrated and modern CI/CD approach.
Highlights
- Deprecation of
OT_REPORTERintegration: TheOT_REPORTERvariable and all associated calls (initialization, size reporting, and post-processing) have been removed from thescript/check-sizeutility. This indicates the removal of an older, external size reporting mechanism. - Preparation for GitHub Actions migration: This change is a preparatory step towards migrating the project's size reporting infrastructure to GitHub Actions, as indicated by the pull request title. The
script/check-sizeis being cleaned up to remove dependencies on the previous reporting system.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The code changes remove the OT_REPORTER variable and related logic from the check-size script. The script defines several functions before they are called, which is not ideal. It's better to define functions before they are called to ensure that the function definition is available when it is needed.
|
|
||
| printf "</details>" >>${OT_REPORT_FILE_PR}_libs | ||
| cat "${OT_REPORT_FILE_PR}_libs" >>${OT_REPORT_FILE_PR} | ||
|
|
||
| if [ -n "${OT_REPORTER}" ]; then | ||
| "${OT_REPORTER}" post | ||
| fi | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The finalize_report function is being defined before it is being called. This can lead to unexpected behavior if the function is modified later in the script. It's best practice to define functions before they are called to ensure that the function definition is available when it is needed. Consider moving this function definition to the top of the script.
fa13fe4 to
feeea84
Compare
feeea84 to
373a724
Compare
e3c4b6c to
42e93ad
Compare
Library files
|
36ea94a to
e1b0955
Compare
e1b0955 to
b1598f0
Compare
b1598f0 to
dfa91fb
Compare
|
+----------------------------+----------+----------+----------+----------+----------+ |
dfa91fb to
4a18b2a
Compare
c2a9d37 to
ec193e9
Compare
ec193e9 to
459d920
Compare
459d920 to
bca15a3
Compare
bca15a3 to
c5061ca
Compare
c5061ca to
6d5333f
Compare
6d5333f to
438d96d
Compare
438d96d to
14c8134
Compare
1bdcaa1 to
b693c15
Compare
This PR is to verify the size report changes.
Depends-On: openthread/ot-nrf528xx#989