Skip to content

Conversation

@bukepo
Copy link
Owner

@bukepo bukepo commented Jul 9, 2025

This PR is to verify the size report changes.

Depends-On: openthread/ot-nrf528xx#989

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @bukepo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the script/check-size utility by removing its integration with the OT_REPORTER external size reporting mechanism. This change is a foundational step in migrating the project's size reporting capabilities to a GitHub Actions-based workflow, aiming for a more integrated and modern CI/CD approach.

Highlights

  • Deprecation of OT_REPORTER integration: The OT_REPORTER variable and all associated calls (initialization, size reporting, and post-processing) have been removed from the script/check-size utility. This indicates the removal of an older, external size reporting mechanism.
  • Preparation for GitHub Actions migration: This change is a preparatory step towards migrating the project's size reporting infrastructure to GitHub Actions, as indicated by the pull request title. The script/check-size is being cleaned up to remove dependencies on the previous reporting system.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The code changes remove the OT_REPORTER variable and related logic from the check-size script. The script defines several functions before they are called, which is not ideal. It's better to define functions before they are called to ensure that the function definition is available when it is needed.

Comment on lines 283 to 290

printf "</details>" >>${OT_REPORT_FILE_PR}_libs
cat "${OT_REPORT_FILE_PR}_libs" >>${OT_REPORT_FILE_PR}

if [ -n "${OT_REPORTER}" ]; then
"${OT_REPORTER}" post
fi
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The finalize_report function is being defined before it is being called. This can lead to unexpected behavior if the function is modified later in the script. It's best practice to define functions before they are called to ensure that the function definition is available when it is needed. Consider moving this function definition to the top of the script.

@bukepo bukepo closed this Jul 9, 2025
@bukepo bukepo reopened this Jul 9, 2025
@bukepo bukepo force-pushed the gh-size-report-test branch from fa13fe4 to feeea84 Compare July 9, 2025 08:18
@bukepo bukepo force-pushed the gh-size-report-test branch from feeea84 to 373a724 Compare July 9, 2025 08:28
@bukepo bukepo force-pushed the gh-size-report-test branch 7 times, most recently from e3c4b6c to 42e93ad Compare July 9, 2025 09:30
@github-actions
Copy link

github-actions bot commented Jul 9, 2025

Merging #19 into main

name branch text data bss total
ot-cli-ftd 3fa8a2a 478264 860 66524 545648
14c8134 478264 860 66628 545752
+/- +0 +0 +104 +104
ot-ncp-ftd 3fa8a2a 444140 764 61768 506672
14c8134 444140 764 61872 506776
+/- +0 +0 +104 +104
ot-cli-mtd 3fa8a2a 371328 764 50988 423080
14c8134 371344 764 50988 423096
+/- +16 +0 +0 +16
ot-ncp-mtd 3fa8a2a 352444 764 46256 399464
14c8134 352460 764 46256 399480
+/- +16 +0 +0 +16
ot-cli-ftd-br 3fa8a2a 575704 868 134036 710608
14c8134 575736 868 134140 710744
+/- +32 +0 +104 +136
ot-rcp 3fa8a2a 63120 568 20804 84492
14c8134 63136 568 20804 84508
+/- +16 +0 +0 +16
Library files
name branch text data bss total
libopenthread-ftd.a 3fa8a2a 245496 95 40302 285893
14c8134 245496 95 40406 285997
+/- +0 +0 +104 +104
libopenthread-cli-ftd.a 3fa8a2a 60743 0 8083 68826
14c8134 60743 0 8083 68826
+/- +0 +0 +0 +0
libopenthread-ncp-ftd.a 3fa8a2a 33257 0 5948 39205
14c8134 33257 0 5948 39205
+/- +0 +0 +0 +0
libopenthread-mtd.a 3fa8a2a 164143 0 24790 188933
14c8134 164143 0 24790 188933
+/- +0 +0 +0 +0
libopenthread-cli-mtd.a 3fa8a2a 41134 0 8059 49193
14c8134 41134 0 8059 49193
+/- +0 +0 +0 +0
libopenthread-ncp-mtd.a 3fa8a2a 25785 0 5948 31733
14c8134 25785 0 5948 31733
+/- +0 +0 +0 +0
libopenthread-ftd-br.a 3fa8a2a 346725 100 107782 454607
14c8134 346777 100 107886 454763
+/- +52 +0 +104 +156
libopenthread-cli-ftd-br.a 3fa8a2a 75982 0 8115 84097
14c8134 75982 0 8115 84097
+/- +0 +0 +0 +0
libopenthread-rcp.a 3fa8a2a 9932 0 5060 14992
14c8134 9932 0 5060 14992
+/- +0 +0 +0 +0
libopenthread-radio.a 3fa8a2a 19383 0 238 19621
14c8134 19383 0 238 19621
+/- +0 +0 +0 +0

@bukepo bukepo force-pushed the gh-size-report-test branch 7 times, most recently from 36ea94a to e1b0955 Compare July 9, 2025 11:01
Repository owner deleted a comment from github-actions bot Jul 9, 2025
@bukepo bukepo force-pushed the gh-size-report-test branch from e1b0955 to b1598f0 Compare July 9, 2025 11:12
@bukepo bukepo force-pushed the gh-size-report-test branch from b1598f0 to dfa91fb Compare July 9, 2025 22:39
@github-actions
Copy link

github-actions bot commented Jul 9, 2025

+----------------------------+----------+----------+----------+----------+----------+
| name | branch | text | data | bss | total |
+============================+==========+==========+==========+==========+==========+
| ot-cli-ftd | b876687 | 477232 | 860 | 66524 | 544616 |
| | 498fd37 | 477232 | 860 | 66524 | 544616 |
| | +/- | +0 | +0 | +0 | +0 |
+----------------------------+----------+----------+----------+----------+----------+
| ot-ncp-ftd | b876687 | 443108 | 764 | 61768 | 505640 |
| | 498fd37 | 443108 | 764 | 61768 | 505640 |
| | +/- | +0 | +0 | +0 | +0 |
+----------------------------+----------+----------+----------+----------+----------+
| ot-cli-mtd | b876687 | 370312 | 764 | 50988 | 422064 |
| | 498fd37 | 370312 | 764 | 50988 | 422064 |
| | +/- | +0 | +0 | +0 | +0 |
+----------------------------+----------+----------+----------+----------+----------+
| ot-ncp-mtd | b876687 | 351428 | 764 | 46256 | 398448 |
| | 498fd37 | 351428 | 764 | 46256 | 398448 |
| | +/- | +0 | +0 | +0 | +0 |
+----------------------------+----------+----------+----------+----------+----------+
| ot-cli-ftd-br | b876687 | 574696 | 868 | 134036 | 709600 |
| | 498fd37 | 574696 | 868 | 134036 | 709600 |
| | +/- | +0 | +0 | +0 | +0 |
+----------------------------+----------+----------+----------+----------+----------+
| ot-rcp | b876687 | 62992 | 568 | 20804 | 84364 |
| | 498fd37 | 62992 | 568 | 20804 | 84364 |
| | +/- | +0 | +0 | +0 | +0 |
+----------------------------+----------+----------+----------+----------+----------+

@bukepo bukepo force-pushed the gh-size-report-test branch from 6d5333f to 438d96d Compare July 15, 2025 15:04
@bukepo bukepo closed this Jul 15, 2025
@bukepo bukepo reopened this Jul 15, 2025
@bukepo bukepo closed this Jul 15, 2025
@bukepo bukepo reopened this Jul 15, 2025
@bukepo bukepo force-pushed the gh-size-report-test branch from 438d96d to 14c8134 Compare July 15, 2025 15:24
@bukepo bukepo force-pushed the main branch 2 times, most recently from 1bdcaa1 to b693c15 Compare July 16, 2025 02:26
@bukepo bukepo closed this Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants