Checkout integration - #4
Open
bullTo wants to merge 70 commits into
Open
Conversation
15 product page
30 made common breadcrumbs component
35 added variant pick animation
36 vertical menu
37 horizontal menu
51 filters mobile
38 updated footer component
32 hid sort icon on inactive filter
bullTo
commented
Mar 3, 2025
bullTo
left a comment
bullTo
left a comment
Owner
Author
There was a problem hiding this comment.
Just reviewed all them of your code.
bullTo
commented
Mar 3, 2025
|
|
||
| if (e.key !== undefined && e.key === 'Escape') { | ||
| closeIfOpened(); | ||
| } else if (e.keyCode !== undefined && e.keyCode === 13) { |
Owner
Author
There was a problem hiding this comment.
Why did you report 2 lines for this?
bullTo
commented
Mar 10, 2025
bullTo
left a comment
bullTo
left a comment
Owner
Author
There was a problem hiding this comment.
What's is the next step?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.