feat: add callback whitelist in frendlend#94
Merged
Conversation
solidoracle
approved these changes
Aug 28, 2025
releasebot-bulla Bot
pushed a commit
that referenced
this pull request
Aug 28, 2025
# [1.22.0](v1.21.0...v1.22.0) (2025-08-28) ### Features * add callback whitelist in frendlend ([#94](#94)) ([3b2c468](3b2c468))
|
🎉 This PR is included in version 1.22.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
0xleastwood
reviewed
Aug 28, 2025
| @@ -499,6 +544,13 @@ contract BullaFrendLendV2 is BullaClaimControllerBase, ERC165, IBullaFrendLendV2 | |||
| revert InvalidCallback(); | |||
| } | |||
There was a problem hiding this comment.
Can probably remove validate callback configuration because it's not whitelisted
0xleastwood
reviewed
Aug 28, 2025
| * @param selector The function selector to whitelist for this contract | ||
| */ | ||
| function addToCallbackWhitelist(address callbackContract, bytes4 selector) external { | ||
| if (msg.sender != admin) revert NotAdmin(); |
There was a problem hiding this comment.
Might as well make this into an onlyAdmin modifier because there are several instances of this being used and readability helps
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.