Skip to content

Conversation

@gazayas
Copy link
Contributor

@gazayas gazayas commented Aug 17, 2023

Fixes #407.

I was able to confirm the fix provided in the issue works by ejecting the webhooks controller and customizing the valid event types.

What I did in the screenshots here:

  1. Ejected the webhooks controller and edited valid_event_types to only allow membership event types
  2. Check @endpoint.valid? yields true in the create action
  3. Temporarily add ALL event types to the record
  4. Ensure the record is invalid when ALL the event types have been added.

The record is also valid when the event types field is left blank.

Screenshot from 2023-08-17 21-46-40

Screenshot from 2023-08-17 21-46-06

@jagthedrummer
Copy link
Contributor

@andrewculver, I'm leaving this one for you since it affects outgoing webhooks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Webhooks::Outgoing::EndpointSupport doesn't enforce valid_event_types.

3 participants