Add Controller Support #11
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwright
force-pushed
the
features/add-controller-support
branch
2 times, most recently
from
b9f961c to
fbdad9c
Compare
jwright
force-pushed
the
features/add-controller-support
branch
2 times, most recently
from
49a69af to
7238314
Compare
jwright
force-pushed
the
features/add-controller-support
branch
from
7238314 to
aded75d
Compare
Contributor
|
@jwright Any idea why this is failing CI? |
jagthedrummer
force-pushed
the
features/add-controller-support
branch
from
d144b40 to
3c60576
Compare
Contributor
|
@jwright @andrewculver I got tests passing on this by rebasing it against |
…t is necessary to enforce usage at a controller level
jwright
force-pushed
the
features/add-controller-support
branch
from
3c60576 to
90155f6
Compare
Contributor
Author
|
@jagthedrummer There is nothing left to do with this PR and it is ready for review/merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
Billing::UsageControllerSupportmodule which adds support for securing actions against usage limits.Closes #2