Skip to content

feat: add contact-cryptokeys plugin UI slot #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
paulhenry46 wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −3
Open

feat: add contact-cryptokeys plugin UI slot #685

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion components/contacts/contact-detail.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ import { ContactActivity } from "./contact-activity";
import { toast } from "@/stores/toast-store";
import { exportContact } from "./contact-export";
import { printContact } from "./contact-print";
import { usePluginSlotOffers } from "@/hooks/use-plugin-slot-offers";
import { PluginSlot } from "@/components/plugins/plugin-slot";

type MoreItem =
| {
Expand Down Expand Up @@ -118,6 +120,7 @@ export function ContactDetail({ contact, onEdit, onDelete, onAddToGroup, onDupli
const t = useTranslations("contacts");

const cryptoKeys = contact?.cryptoKeys ? Object.values(contact.cryptoKeys) : [];
const hasCryptoKeysSlotOffers = usePluginSlotOffers('contact-cryptokeys').length > 0;

if (!contact) {
return (
Expand Down Expand Up @@ -426,7 +429,12 @@ export function ContactDetail({ contact, onEdit, onDelete, onAddToGroup, onDupli
{cryptoKeys.length > 0 && (
<Section title={t("detail.crypto_keys")}>
<div className="space-y-3">
{cryptoKeys.map((key, i) => (

{hasCryptoKeysSlotOffers && (
<PluginSlot name="contact-cryptokeys" extraProps={{ cryptoKeys }} />
)}

{!hasCryptoKeysSlotOffers &&cryptoKeys.map((key, i) => (
<div key={i} className="rounded-md border border-border/60 bg-muted/30 p-3 space-y-1">
<div className="flex items-start gap-2 text-sm break-all">
<KeyRound className="w-4 h-4 text-muted-foreground mt-0.5 flex-shrink-0" />
Expand Down
1 change: 1 addition & 0 deletions lib/__tests__/plugin-types.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ describe('plugin-types constants', () => {
expect(ALL_PERMISSIONS).toContain('ui:toolbar');
expect(ALL_PERMISSIONS).toContain('ui:email-banner');
expect(ALL_PERMISSIONS).toContain('ui:email-footer');
expect(ALL_PERMISSIONS).toContain('ui:contact-cryptokeys');
expect(ALL_PERMISSIONS).toContain('ui:composer-toolbar');
expect(ALL_PERMISSIONS).toContain('ui:sidebar-widget');
expect(ALL_PERMISSIONS).toContain('ui:settings-section');
Expand Down
5 changes: 3 additions & 2 deletions lib/plugin-types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,8 @@ export type SlotName =
| 'context-menu-email'
| 'navigation-rail-bottom'
| 'calendar-event-actions'
| 'admin-plugin-page';
| 'admin-plugin-page'
| 'contact-cryptokeys';

export interface SlotRegistration {
pluginId: string;
Expand Down Expand Up @@ -1036,7 +1037,7 @@ export const ALL_PERMISSIONS = [
'security:read',
'auth:observe',
'http:post', 'http:fetch',
'ui:observe', 'ui:toolbar', 'ui:app-top-banner', 'ui:email-banner', 'ui:email-footer',
'ui:observe', 'ui:toolbar', 'ui:app-top-banner', 'ui:email-banner', 'ui:email-footer', 'ui:contact-cryptokeys',
'ui:email-details',
'ui:download-file',
// Register native message-list category tabs (Gmail-style inbox tabs).
Expand Down