feat: add patch ingress.status.loadbalancerIp #2246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
When we use bunkerweb on Kubernetes. Bunkerweb does not patch the ingress.status object with the loadbalancerIP ip.
This PR allows Bunkerweb to patch the ingress.status.loadbalancerIP field with the IP of the loadbalancer exposed for bunkerweb.
For Bunkerweb to patch the ingress object, it must have the update right in its clusterRole to update
ingresses/status. It must also know the name of the Kubernetes service through which it is exposed by a LoadBalancer type service, this is done by aBUNKERWEB_SERVICE_NAMEenvironment variable and itsBUNKERWEB_NAMESPACEnamespace.