Road to 1.6.6 🚀

CHANGELOG.md

@@ -6,6 +6,7 @@
 - [FEATURE] Enhance default server configuration: when IP is whitelisted, serve the "nothing to see here" page even if the default server is deactivated.
 - [BUGFIX] Fix default rate limit for POST /auth endpoint with API service
 - [BUGFIX] Fix instant ban when using bad behavior with redis if the ban time is set to 0 (permanent ban)
+- [BUGFIX] Fix "no memory" errors on metrics
 - [LINUX] Enhance Easy Install script with manager and worker mode configurations
 - [UI] Enhance bad behavior logging and UI actions with additional fields and filtering capabilities
 - [UI] Optimize the reports page export functionality for large datasets by implementing server-side processing to handle data exports in manageable chunks, reducing memory usage and improving performance.

src/common/core/metrics/metrics.lua

@@ -254,29 +254,13 @@ function metrics:timer()
 		if type(value) == "table" then
 			value = encode(value)
 		end
-		-- Push to dict
+		-- Push to dict (with LRU eviction if needed)
 		local ok
-		ok, err = self.metrics_datastore:set(key .. "_" .. wid, value)
+		ok, err = self.metrics_datastore:set_with_retries(key .. "_" .. wid, value)
 		if not ok then
-			-- Fallback to direct set with LRU eviction if needed
-			if err == "no memory" then
-				local max_retries = tonumber(self.variables["METRICS_MEMORY_MAX_RETRIES"]) or 5
-				for attempt = 1, max_retries do --luacheck:ignore 213
-					ok, err = self.metrics_datastore.dict:set(key .. "_" .. wid, value)
-					if ok or err ~= "no memory" then
-						break
-					end
-				end
-				if not ok then
-					ret = false
-					ret_err = err
-					self.logger:log(ERR, "can't set " .. key .. "_" .. wid .. " : " .. err)
-				end
-			else
-				ret = false
-				ret_err = err
-				self.logger:log(ERR, "can't (safe) set " .. key .. "_" .. wid .. " : " .. err)
-			end
+			ret = false
+			ret_err = err
+			self.logger:log(ERR, "can't (safe) set " .. key .. "_" .. wid .. " : " .. err)
 		end
 	end