Skip expiring logs for SQS ingest/file loader #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was turned off for commit builder in d7d1f23 That change wasn't used by SQS ingest and file loader lambdas, because they call flush_and_commit which uses default commit properties. This commit changes to use .flush, and then commits Add action via existing function that doesn't expire logs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was turned off for commit builder in d7d1f23 (#36)
That change wasn't used by SQS ingest and file loader lambdas, because they call
flush_and_commitwhich uses default commit properties.https://github.com/delta-io/delta-rs/blob/b351f77e39c1e8d6ced60d3146a4971220da9dd2/crates/core/src/writer/mod.rs#L177
This PR changes to use
.flush, and then commits Add action via existing function that doesn't expire logs