Reset backoff state after non-retryable API errors - #1596
Merged
antoineeripret merged 2 commits intoJul 16, 2026
Merged
Conversation
Collaborator
|
Hey @lovewave02, Thank you for the PR, love it :) Can you apply the same change to Thank you ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
A non-retryable API error currently increments
BackOffHTTPClient's retrycounter before the error is returned. If the same client later hits a retryable
error, its first delay starts at 4 seconds instead of 2 seconds.
This resets the counter before propagating a terminal API error. The regression
test exercises a 403 -> 500 -> success sequence and verifies that the 500 starts
with the normal 2-second delay.
Verification
tox -e lint,py,build,doc