fix(ci): robust artifact placement in goreleaser#562
Merged
Conversation
Replace fragile `mv */xiond*` glob with explicit find-and-place logic that creates the exact directory structure goreleaser's prebuilt builder expects (dist/xiond_<os>_<arch>_<variant>/bin/xiond-<os>-<arch>). The old glob relied on upload-artifact preserving a specific directory hierarchy, which doesn't work reliably with merge-multiple downloads. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2 tasks
2xburnt
added a commit
that referenced
this pull request
Apr 20, 2026
## Summary - When `SKIP_GITHUB_RELEASE=true` (non-tag `workflow_dispatch` runs), goreleaser fails at the homebrew formula step because it can't resolve download URLs without an active release - Adds a pre-step that checks `SKIP_GITHUB_RELEASE` and appends `homebrew` to the skip flags - On real tag pushes (where `SKIP_GITHUB_RELEASE` is not set), homebrew runs normally ## Context This was the remaining failure from the create-release workflow test run after #561 and #562 fixed the binary extraction and artifact placement. ## Test plan - [ ] Trigger `create-release.yaml` via `workflow_dispatch` — should pass fully now - [ ] Real tag push still generates homebrew formula (SKIP_GITHUB_RELEASE not set) 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Signed-off-by: TwiceBurnt <169301814+2xburnt@users.noreply.github.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
exec-goreleaser.yaml"Move artifacts" step which failed withno such file or directoryafter the extract-from-docker change (fix(ci): extract linux binaries from Docker images #561)mv ${{ runner.temp }}/*/xiond* distglob relied on a specific directory hierarchy from upload-artifact that isn't guaranteed withmerge-multiple: truefindto locate allxiond-*binaries, parses os/arch from filenames, and creates the exact directory structure goreleaser'sprebuiltbuilder expects:dist/xiond_<os>_<arch>_<variant>/bin/xiond-<os>-<arch>Test plan
create-release.yamlviaworkflow_dispatchon this branch🤖 Generated with Claude Code