Skip to content

Introduce auto_confirmed option for 'maintenance uninstall' task #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tduccuong wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Introduce auto_confirmed option for 'maintenance uninstall' task #165

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1576d1a
New sub-command to uninstall the cached version without confirming
tduccuong Dec 25, 2024
f3d9564
introduce auto_confirm option for 'maintenance uninstall' task
tduccuong Dec 25, 2024
55f0a58
use '--no-confirm' instead of 'confirmed' for uninstall task
tduccuong Jan 16, 2025
81f1457
skip specific nifs or all
tduccuong Jan 30, 2025
3f89a0a
print log for skipped nifs
tduccuong Jan 30, 2025
52eba6b
make sure dep name extracted from tuple
tduccuong Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 17 additions & 7 deletions src/maintenance.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@ pub fn do_maint(args: [][]u8, install_dir: []const u8) !void {
logger.warn("No sub-command provided!", .{});
} else {
if (std.mem.eql(u8, args[0], "uninstall")) {
try do_uninstall(install_dir);
const confirmed = args.len >= 2 and std.mem.eql(u8, args[1], "confirmed");
try do_uninstall(install_dir, confirmed);
Copy link
Contributor

@doawoo doawoo Jan 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nitpick, but I would prefer this be called the inverse: -no-confirm or something like that.

Copy link
Author

@tduccuong tduccuong Jan 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i changed the option to --no-confirm :)

}

if (std.mem.eql(u8, args[0], "directory")) {
Expand Down Expand Up @@ -41,12 +42,14 @@ fn confirm() !bool {
}
}

fn do_uninstall(install_dir: []const u8) !void {
logger.warn("This will uninstall the application runtime for this Burrito binary!", .{});
if ((try confirm()) == false) {
logger.warn("Uninstall was aborted!", .{});
logger.info("Quitting.", .{});
return;
fn do_uninstall(install_dir: []const u8, auto_confirmed: bool) !void {
if (!auto_confirmed) {
logger.warn("This will uninstall the application runtime for this Burrito binary!", .{});
if ((try confirm()) == false) {
logger.warn("Uninstall was aborted!", .{});
logger.info("Quitting.", .{});
return;
}
}

logger.info("Deleting directory: {s}", .{install_dir});
Expand All @@ -55,6 +58,13 @@ fn do_uninstall(install_dir: []const u8) !void {
logger.info("Quitting.", .{});
}

fn do_uninstall_confirmed(install_dir: []const u8) !void {
logger.info("Deleting directory: {s}", .{install_dir});
try std.fs.deleteTreeAbsolute(install_dir);
logger.info("Uninstall complete!", .{});
logger.info("Quitting.", .{});
}

fn print_metadata() !void {
var stdout = std.io.getStdOut().writer();
stdout.print("{s}", .{wrapper.RELEASE_METADATA_JSON}) catch {};
Expand Down