feat: support proxy for download fetch #204
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doawoo
requested changes
Nov 21, 2025
Comment on lines
+102
to
+122
| resp = | ||
| cond do | ||
| proxy = System.get_env("HTTP_PROXY") || System.get_env("http_proxy") -> | ||
| Log.info(:step, "Using HTTP_PROXY: #{proxy}") | ||
| URI.parse(proxy) | ||
|
|
||
| proxy = System.get_env("HTTPS_PROXY") || System.get_env("https_proxy") -> | ||
| Log.info(:step, "Using HTTPS_PROXY: #{proxy}") | ||
| URI.parse(proxy) | ||
|
|
||
| true -> | ||
| nil | ||
| end | ||
| |> case do | ||
| %{scheme: scheme, host: host, port: port} when scheme in ["http", "https"] -> | ||
| proxy = {String.to_atom(scheme), host, port, []} | ||
| Req.get!(url, raw: true, connect_options: [proxy: proxy]) | ||
|
|
||
| _ -> | ||
| Req.get!(url, raw: true) | ||
| end |
Contributor
There was a problem hiding this comment.
since this code is duplicated twice, maybe it would be best to move it into a function under the Util module, and have it return either URI.t() | nil -- then we can just pass that into the proxy key and do a single Req.get! call, so we don't need to have the cond piping into a case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #200