Open
Conversation
When using connect-policies based on GIDs, the launcher incorrectly used an uninitialized UID as key, rather than the stored GID. Fix this to properly use the GID defined in the XML configuration. This effectively means that connect-policies based on GIDs never worked. But luckily, no distributor makes use of those, so this should have a negligible impact. Reported-by: Pavel Kohout, Aisle Research, Aisle.com Signed-off-by: David Rheinsberg <david@readahead.eu>
Ensure that truncated log messages are properly recovered from, rather than forwarding their error to the caller. The log infrastructure already has sufficient handling of dropped log messages, so make use of it for truncated messages as well. Note that under special circumstances, clients can currently trigger truncated log messages and thus terminate the broker, even though the log instances are marked as `lossy`. However, this requires clients to trigger a log message that got truncated. There is no known way how unprivileged clients can do this, though. However, clients with access to wildcard name-ownership can currently claim more names than a log message can hold, and thus trigger log messages that will be truncated. Since this is limited to privileged clients, the impact of this should be low to negligible. Reported-by: Pavel Kohout, Aisle Research, Aisle.com Signed-off-by: David Rheinsberg <david@readahead.eu>
Ensure that the sockopt-test passes addresses as `struct sockaddr *` rather than the typed `struct sockaddr_un*`, to honor the prototypes of the respective socket syscalls. Reported-by: Kostadin Shishmanov <kostadinshishmanov@protonmail.com> Signed-off-by: David Rheinsberg <david@readahead.eu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
3 unrelated fixes. See each commit message for details.