feat: add json rule #126
Open
feat: add json rule #126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
jsonkind as an ignore rule. This rule parses JSON in resource attributes and, if valid, compares the parsed objects. I personally used it for refactoring ElasticSearch objects where templates and policies are stored in JSON. I found that example too unusual to use it in the docs, so I simply usedlocal_filethere.Currently, when the object cannot be parsed as JSON, the rule simply returns
false. It could be better to resort to string comparison, but I'm not sure what the expected behavior would be.