You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@knownasilya Sorry for the delay. Thanks for submitting. I don't think we had previously considered that the cards or atoms in a mobiledoc would remain "live" after rendered by ember-mobiledoc-dom-renderer. I am pleasantly surprised that this works. :)
Are you wanting to call env.save so that you can update the mobiledoc JSON output? And/or is there a reason that you couldn't modify the Ember component's properties to effect a change in the rendered template? That was more the expectation for this dom renderer.
@knownasilya@bantic Could this PR be modified to also pass the env to the card component? I am in a situation where I am trying to leverage env.isInEditor in my Card component per the mobledoc Card API. Or would it be better to create a new PR to add that functionality?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows the component to control things like
env.save(value, payload)to trigger a rerender of the atom or to handle teardown.