Skip to content

fix: Increase default httpx timeout and expose timeout parameter (#202)#203

Open
bvanelli wants to merge 2 commits into
mainfrom
fix/httpx-commit-timeout
Open

fix: Increase default httpx timeout and expose timeout parameter (#202)#203
bvanelli wants to merge 2 commits into
mainfrom
fix/httpx-commit-timeout

Conversation

@bvanelli
Copy link
Copy Markdown
Owner

@bvanelli bvanelli commented May 12, 2026

Summary

  • The httpx client in ActualServer was created without an explicit timeout, so httpx's default 5s applied to every request — including /sync/sync. This caused intermittent httpcore.ReadTimeout errors on actual.commit() for users on slower servers or larger payloads (httpcore.ReadTimeout: The read operation timed out on actual.commit() #202).
  • The Node.js Actual client imposes no timeout at all on the binary sync endpoint, so 5s is materially stricter than upstream.
  • This PR raises the default to 60s and exposes a timeout constructor parameter on both ActualServer and Actual. Accepts a float, None (disabled), or an httpx.Timeout object for fine-grained control.

Closes #202.

🤖 Generated with Claude Code

bvanelli and others added 2 commits May 12, 2026 19:23
…er (#202)

Closes #202.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented May 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.62%. Comparing base (5680e04) to head (9fe6834).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #203   +/-   ##
=======================================
  Coverage   97.62%   97.62%           
=======================================
  Files          21       21           
  Lines        3237     3238    +1     
=======================================
+ Hits         3160     3161    +1     
  Misses         77       77           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

httpcore.ReadTimeout: The read operation timed out on actual.commit()

1 participant