Allow using zlib-rs for more than 2x speedup and improved memory safety#29
Open
Shnatsel wants to merge 2 commits intobvibber:mainfrom
Open
Allow using zlib-rs for more than 2x speedup and improved memory safety#29Shnatsel wants to merge 2 commits intobvibber:mainfrom
Shnatsel wants to merge 2 commits intobvibber:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switches over to zlib-rs by default. On my machine this improves the reported time by
mtpngCLI from 128ms to 55ms on this image: https://commons.wikimedia.org/wiki/File:Diagram_Integrasi_Transportasi_Publik_Semarang.pngAllows selecting plain old zlib via Cargo features just in case it's needed for some sort of C program linking not to blow up. I don't actually know if they will blow up or not, so I decided to err on the side of caution.