Update dependencies #70
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These currently require raw-window-handle to be at version 0.5 to interoperate, until glutin gets updated to use 0.6. I had to remove support for headless rendering, but will try to add that back at some point, if possible using EGL_KHR_surfaceless_context to avoid the dependency on winit in that case. The event loop now runs forever and gets started in main(), instead of the previous way where it ran on demand from the GltfViewer. This accommodates for platforms which don’t let us run it on demand.
This has only been tested on Wayland against rust-windowing/winit#3656 and allows much nicer interactions when using a touchpad. The values have been chosen based on what felt pleasant to use on my Thinkpad x280, I haven’t given it much thought otherwise, and I expect other touchpads would feel different.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #69, while also updating glutin to 0.31 and winit to 0.30.
These currently require raw-window-handle to be at version 0.5 to interoperate, until glutin gets updated to use 0.6.
I had to remove support for headless rendering, but will try to add that back at some point, if possible using
EGL_KHR_surfaceless_contextto avoid the dependency on winit in that case.The event loop now runs forever and gets started in
main(), instead of the previous way where it ran on demand from theGltfViewer. This accommodates for platforms which don’t let us run it on demand.The second commit implements touchpad gestures, and has been tested on Wayland against rust-windowing/winit#3656