feat(cli): render full ThreatMap.v1 dataflow in findings show - #16
Merged
Conversation
renderThreatMap collapsed each path to a single [source] -> [sink] line, discarding the transforms (the actual dataflow), per-path confidence, bypassable guards, and the summary block that omv threat-map init now writes. Complete the read side to match the producer: - Multi-line rendering per path: source, each transform, sink, guard (present/missing, bypassable flag), confidence in the path header. - Optional summary line (path_count, confirmed_paths, highest_confidence). - describeThreatNode now surfaces location alongside the label. - Updated the pinned read test to the richer format and added a test covering transforms, confidence, bypassable guard, and summary. 37 tests pass; full validate green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Completes the read side of the ThreatMap.v1 pipeline to match the producer merged in #15. `renderThreatMap` collapsed each path to a single `[source] -> [sink]` line, discarding the `transforms` (the actual dataflow), per-path `confidence`, bypassable guards, and the `summary` block — all of which `omv threat-map init` now writes.
Validation