MBS-10663: Fix date/duration view switch not being idempotent#13
Open
MBS-10663: Fix date/duration view switch not being idempotent#13
Conversation
Barbuia
force-pushed
the
MBS-10663-Fix_date_switch_not_idempotent
branch
3 times, most recently
from
d5c6f78 to
1722b16
Compare
PhMemmel
requested changes
Apr 1, 2026
Member
PhMemmel
left a comment
PhMemmel
left a comment
There was a problem hiding this comment.
Switching between now works, but it's getting out of sync with the stored value.
What works:
- Configure target time: 02.04.2026 9:50
- Save
- Info field shows 02.04.2026 9:50 as target time
What does not work:
- Configure target time: 02.04.2026 09:50
- Switch to count down selector
- Save
- Info field shows 02.04.2026 9:49, or sometimes even 9:48
Refactored updateTargetTime into two separate functions: - updateTargetTimeFromCurrentView(): reads value from visible view - updateDisplayValues(): syncs both UI elements from stored time This ensures switching between date and duration views preserves the exact same target time without rounding drift.
Barbuia
force-pushed
the
MBS-10663-Fix_date_switch_not_idempotent
branch
from
1722b16 to
1d2e582
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored updateTargetTime into two separate functions:
This ensures switching between date and duration views preserves the exact same target time without rounding drift.