Conversation
|
Thank you @lucaboesch ! Any idea why these flaws have not been recognized by the GHA? If the pipeline is green but should not be, we should definitely fix it! |
PhMemmel
left a comment
PhMemmel
left a comment
There was a problem hiding this comment.
Thank you very much for sending this PR.
You apparently were running local_moodlecheck on this.
The reason we do not have these checks in the pipeline is that this plugin is going to be deprecated (or is already): https://github.com/moodlehq/moodle-local_moodlecheck/blob/main/README.md
All sniffs will be integrated in the phpcs, so we do not have the phpdoc checks this in our pipeline. Apparently the checks for missing and wrong function parameters in the PHPDoc is not yet working in the new phpcs which is why this PR makes sense. Just have some minor recommendations left.
See also moodlehq/moodle-cs#30 and https://moodle.org/mod/forum/discuss.php?d=455786
lucaboesch
force-pushed
the
codechecker
branch
from
bc1e17d to
a925cb7
Compare
2 participants
No description provided.