MBS-10346: Allow more characters for tenant names#113
Open
HannesFunk wants to merge 8 commits intomainfrom
Open
MBS-10346: Allow more characters for tenant names#113HannesFunk wants to merge 8 commits intomainfrom
HannesFunk wants to merge 8 commits intomainfrom
Conversation
HannesFunk
force-pushed
the
MBS-10346_Allow_blank_spaces_in_tenant
branch
from
c85f7fe to
851dfdb
Compare
PhMemmel
requested changes
Mar 16, 2026
PhMemmel
changed the title
PhMemmel
force-pushed
the
MBS-10346_Allow_blank_spaces_in_tenant
branch
from
9c5d060 to
d5f226c
Compare
PhMemmel
requested changes
Mar 23, 2026
Member
There was a problem hiding this comment.
This should not be part of this branch, have you rebased the branch? If not, please do.
tests/local/tenant_test.php
Outdated
| * @dataProvider identifier_provider | ||
| * @covers \local_ai_manager\local\tenant::__construct | ||
| */ | ||
| public function test_validation($name, $valid): void { |
Member
There was a problem hiding this comment.
Suggested change
| public function test_validation($name, $valid): void { | |
| public function test_tenant_name_validation($name, $valid): void { |
tests/local/tenant_test.php
Outdated
| * | ||
| * @return array | ||
| */ | ||
| public static function identifier_provider(): array { |
Member
There was a problem hiding this comment.
Data providers always have to have a specific name scheme which is "test method name with leading test_ prefix"_provider
Please also add some description to @return array
HannesFunk
force-pushed
the
MBS-10346_Allow_blank_spaces_in_tenant
branch
from
489de93 to
afc0ebe
Compare
PhMemmel
force-pushed
the
MBS-10346_Allow_blank_spaces_in_tenant
branch
from
afc0ebe to
2ef9a15
Compare
added 7 commits
March 23, 2026 12:04
PhMemmel
force-pushed
the
MBS-10346_Allow_blank_spaces_in_tenant
branch
from
2ef9a15 to
5cc41a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.