MBS-10621: Custom endpoints without azure options#118
Conversation
PhMemmel
changed the title
Snl-FGH
force-pushed
the
MBS-10621-Custom_endpoints_without_azure_options
branch
from
c61068b to
f4d0d0b
Compare
PhMemmel
left a comment
PhMemmel
left a comment
There was a problem hiding this comment.
I have not yet completed the initial review, but sending this over to you so far for a first round.
…ertex cache status in Google AI
Snl-FGH
force-pushed
the
MBS-10621-Custom_endpoints_without_azure_options
branch
from
400e458 to
4571569
Compare
| . $deploymentid . '/chat/completions?api-version=' . $apiversion; | ||
| // We have an empty model because the model is preconfigured if we're using azure. | ||
| // So we overwrite the default "preconfigured" value by a better model name. | ||
| $enabled = aitool_option_azure::extract_azure_data_to_store($data); |
There was a problem hiding this comment.
well, it's a little break in the data structure maybe. There were multiple attributes, you now reduce the return value of the function to just one return value.
On the other hand add_azure_options_to_form_data is staying with returning a whole object.
Not sure if we need to change this again. It just feels a little bit inconsistent. But on the other hand probably won't matter :)
There was a problem hiding this comment.
You're right, it's a bit asymmetric. The two functions just serve different purposes, so their return types ended up different. Happy to change it if you feel strongly about it though :)
2 participants
No description provided.