Open
Conversation
sh-csg
force-pushed
the
MBS-9943-Mistral-AI-tool
branch
3 times, most recently
from
ab8397f to
fbaa966
Compare
sh-csg
force-pushed
the
MBS-9943-Mistral-AI-tool
branch
from
fbaa966 to
d2d7ddf
Compare
PhMemmel
requested changes
Jul 30, 2025
| 'feedback' => $models, | ||
| 'singleprompt' => $models, | ||
| 'translate' => $models, | ||
| 'itt' => ['pixtral-large-latest'], |
Member
There was a problem hiding this comment.
Please also add purpose questiongeneration here
| * @author Stefan Hanauska <stefan.hanauska@csg-in.de> | ||
| * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later | ||
| */ | ||
| class connector extends \local_ai_manager\base_connector { |
Member
There was a problem hiding this comment.
It looks like the mistral API is pretty identical to the OpenAI API. So I recommend to inherit from \aitool_chatgpt\connector instead from base_connector and only overwrite the methods that needs to be overwritten. An alternate approach would be to use a wrapper pattern like in #74. But in this case I believe inheriting from \aitool_chatgpt\connector would be the easier approach.
| * Connector for Mistral AI. | ||
| * | ||
| * @package aitool_mistral | ||
| * @copyright ISB Bayern, 2025 |
Member
There was a problem hiding this comment.
Guess that's the convention we are using? :)
Suggested change
| * @copyright ISB Bayern, 2025 | |
| * @copyright 2025 ISB Bayern |
| * aitool_mistral privacy provider class. | ||
| * | ||
| * @package aitool_mistral | ||
| * @copyright ISB Bayern, 2025 |
Comment on lines
+17
to
+24
| /** | ||
| * aitool_mistral privacy provider class. | ||
| * | ||
| * @package aitool_mistral | ||
| * @copyright ISB Bayern, 2025 | ||
| * @author Stefan Hanauska <stefan.hanauska@csg-in.de> | ||
| * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later | ||
| */ |
Member
There was a problem hiding this comment.
Remove, no need for this extra phpdoc if you have a class phpdoc
| * Lang strings for aitool_mistral - EN. | ||
| * | ||
| * @package aitool_mistral | ||
| * @copyright ISB Bayern, 2025 |
| * Version file for aitool_mistral. | ||
| * | ||
| * @package aitool_mistral | ||
| * @copyright ISB Bayern, 2025 |
PhMemmel
changed the title
PhMemmel
reviewed
Jul 30, 2025
| * Instance class for the connector instance of aitool_mistral. | ||
| * | ||
| * @package aitool_mistral | ||
| * @copyright ISB Bayern, 2025 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.